Benjamins Corrections (v1)

[VanLaareN]

Short description
First batch of Benjamins corrections

Details
TODOs

Subtasks

---

1. Topology and Naming Conventions

• Ensure the name is included in the topology.
• Update the controller examples to match the current version (v3). The version of examples is v1, so it needs to be ported to v2 first and then to v3. Particularly be aware of naming conventions. Refer to the [naming conventions guide](https://precice.org/community-contribute-to-precice.html#naming-conventions).
• Redesign the topology to align with current best practices; do not adhere to the old topology.

---

2. Missing Elements in the Porting Guide

• Review and confirm if the missing elements in the [porting guide](Move and rename optional attribute #28) need implementation.
• Check and respond to the issue [#28](Move and rename optional attribute #28).
• Decide if other issues need attention, and confirm whether you should review them.

---

3. Mappings Implementation

• Reassess the current mapping implementation in the pull request [#34](RBF Config fix #34).
• Verify and correct the mappings as necessary, referring to the discussion in issue [#7](Implement version upgrade of precice-config generator #7).

---

4. General Topics

• Investigate why tutorials are included as submodules and determine if this approach is necessary.
• Ensure compatibility with Python 3.11 (Dependencies are missing in Python 3.8).
• Update the README to include a reference to the Controller repository.

---

5. Controller Example Execution

• Test the controller example using:

  python FileGenerator.py -f controller_utils/examples/1/topology.yaml

• Update the generated output to match the expected structure:

  fluid-su2/
    run.sh
    adapter-config.json
  solid-calculix/
    run.sh
    adapter-config.json
  README.md
  clean.sh
  

---

6. PreCICE Configuration

• Remove unnecessary elements:
  • <log/>
  • <profiling synchronize="on" mode="fundamental"/>
  • valid-digits="8"
  • <filter type="QR1" limit="1e-06"/>
  • <initial-relaxation value="0.1"/>
  • <max-used-iterations value="50"/>
  • <timesteps-reused value="8"/>
• Rename configurations:
  • post-processing → acceleration
• Fix Exchange settings:
  • Ensure the exchange is performed on the correct mesh. Use the Config Visualizer or the tool suggested by colleagues.

---

7. Adapter Configuration

• Switch to the latest adapter configuration schema:

  • [Adapter Config Schema Repository](https://github.com/precice/preeco-orga/tree/main/adapter-config-schema)
  • [Issue Reference](Adapter and tool configuration schema precice/preeco-orga#18)

• Tried fixing this in work/toddel/46-7.-Adapter-Configuration branch. No Pull Request yet, because not sure if the result is wanted.

---

**8.Porting from v1 to v2 **

• Use the porting guide to also implement these changes, because the original code is v1 #50

Dependencies
This task depends on ... to be finished