-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model non-existant read and write directions in schema #30
Comments
Apparently, this is not a technical restriction (anymore?), and I modified the adapter to support both: precice/openfoam-adapter#348
I would ask for a specific one of the options, but not forbid supporting both (which I guess you are not suggesting anyway). I think that option 2 (omitted) would be the more intuitive, given what we are used to in other contexts. |
Not exactly. I think it would be better to forbid the other one in the schema. Otherwise, we get interoperability issues. Imagine converting the config of an OpenFOAM case to another solver. Of course, an adapter could still support the other variant as deprecated. |
But then this also gets annoying when one is experimenting with different options. For example, in the fluid-fluid coupling studies, we often had to toggle which fields we read and write. Having to constantly enable/disable a list because it ends up being empty sounds loosely-motivated to me. As a user, I would expect an empty list to be the same as an omitted list. We could give warnings in the validation step that this might not work with all adapters. |
I see the point. If a GUI is used, this could still be one click only.
I am not sure if JSON schema supports such warnings. @Logende What is your view on this? This must be a common problem in configurations, right? |
Sometimes, read or write data does not exist. For instance, for uni-directional coupling or if multiple meshes are used.
How should we model such situations in the schema?
Option 1: Empty arrays
read_data_names
is an empty array.Option 2: Leave array out
read_data_names
does not exist.Remarks
The text was updated successfully, but these errors were encountered: