Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iceberg property names in IcebergTableProperties #24483

Open
ZacBlanco opened this issue Feb 4, 2025 · 0 comments
Open

Use iceberg property names in IcebergTableProperties #24483

ZacBlanco opened this issue Feb 4, 2025 · 0 comments
Labels
feature request iceberg Apache Iceberg related

Comments

@ZacBlanco
Copy link
Contributor

ZacBlanco commented Feb 4, 2025

Currently, Iceberg has a number of table properties available that can be set such as (non-exhaustive):

  • format
  • location
  • commit_retries
  • delete_mode
  • etc..

These properties are presto-specific names that we map to properties in the Iceberg library. One example is that we map delete_mode to write.delete.mode. This creates an extra layer of indirection - and potentially confusion - for the users of the Iceberg connector in Presto.

It's common for users to refer to the iceberg library when configuring tables for updates, deletes, etc. Instead of having to document our name mapping to iceberg's mapping it would be better if we just adopted using the same property names as in the Iceberg library. It should be less error-prone and more straightforward since we won't have to do any mapping of property names to one another. Then, in our documentation we can just include a list of the supported properties and link to Iceberg description of them.

The big caveat is that we'll somehow need to support backwards compatibility for the existing properties while also updating and using the new property names going forward. We should warn about the deprecation to users and eventually remove the old property names after a few releases.

Expected Behavior or Use Case

Table property names in SHOW CREATE TABLE and CREATE TABLE statements should match those in the Iceberg documentation, rather than use our own naming scheme.

Presto Component, Service, or Connector

Iceberg connector.

Possible Implementation

Suggestion here

Context

Initial discussion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request iceberg Apache Iceberg related
Projects
Status: 🆕 Unprioritized
Development

No branches or pull requests

1 participant