Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Double Apostrophe in <value> URI Formatting Issue #838

Open
Alfystar opened this issue Jan 22, 2025 · 2 comments
Open

Bug: Double Apostrophe in <value> URI Formatting Issue #838

Alfystar opened this issue Jan 22, 2025 · 2 comments

Comments

@Alfystar
Copy link

Description:
I encountered a problem with the @prettier/plugin-xml plugin. When an XML file contains the text:

<value>&apos;&apos;</value>

Image

Prettier rewrites it as:

<value>
    &apos; &apos;
</value>

Image

This formatting adds an unwanted space between the apostrophes, which disrupts the appearance of our system.

Steps to Reproduce:

  1. Create an XML file with the following content:
    <root>
        <value>&apos;&apos;</value>
    </root>
  2. Run Prettier with the @prettier/plugin-xml plugin.
  3. Observe the formatted output.

Expected Behavior:
The content of the <value> tag should remain <value>&apos;&apos;</value> without adding spaces.

Actual Behavior:
The content of the <value> tag is rewritten as:

<value>
    &apos; &apos;
</value>

Additional Information:
In other cases, when there is only one apostrophe, Prettier formats correctly by keeping the line together:

<values>
    <field>ITA_IFM_ActivityDescription__c</field>
    <value xsi:type="xsd:string">MEDIA COMPLESSITA&apos;</value>
</values>

This leads us to believe it is a minor bug. Could you please provide feedback?

Prettier Configuration:

{
    "plugins": ["prettier-plugin-apex", "@prettier/plugin-xml"],
    "printWidth": 600,
    "singleQuote": true,
    "trailingComma": "all",
    "bracketSpacing": false,
    "useTabs": true,
    "bracketSameLine": true,
    "apexInsertFinalNewline": false,
    "overrides": [
        {
            "files": "*.{trigger,cls}",
            "options": {"parser": "apex"}
        },
        {
            "files": "*.{apex}",
            "options": {"parser": "apex-anonymous"}
        },
        {
            "files": "**/lwc/**/*.html",
            "options": {"parser": "lwc"}
        },
        {
            "files": "*.{cmp,page,component,evt}",
            "options": {
                "parser": "html",
                "trailingComma": "none"
            }
        },
        {
            "files": "**/aura/**/*.js",
            "options": {"trailingComma": "none"}
        },
        {
            "files": "**/aura/**/*.{auradoc,design,app}",
            "options": {"parser": "angular"}
        },
        {
            "files": "**/*.xml",
            "options": {
                "parser": "xml",
                "useTabs": false,
                "tabWidth": 4,
                "xmlWhitespaceSensitivity": "preserve",
                "embeddedLanguageFormatting": "off",
                "xmlSelfClosingSpace": false
            }
        }
    ]
}

and this is our package.json

{
  "name": "***",
  "version": "1.0.0",
  "author": "***",
  "devDependencies": {
    "@prettier/plugin-xml": "^3.4.1",
    "prettier": "^3.4.2",
    "prettier-plugin-apex": "^2.2.2"
  },
  "repository": {
    "type": "****",
    "url": "****"
  },
  "scripts": {
    "prettier": "prettier"
  },
  "dependencies": {
    "sfdx-plugin-source-read": "^1.4.0"
  }
}

Thanks in advice, i'm here if you need anything else 😊

@Alfystar
Copy link
Author

Have you news about this bug?

@Alfystar
Copy link
Author

Excuse me, can I at least know if you consider this a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant