Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Refactor: clean up duplicated keccak_table #499

Closed
KimiWu123 opened this issue Oct 26, 2023 · 3 comments
Closed

Refactor: clean up duplicated keccak_table #499

KimiWu123 opened this issue Oct 26, 2023 · 3 comments
Assignees
@mmjahanara
Labels
good first issue Good for newcomers T-refactor Type: cleanup/refactor

Comments

@KimiWu123
Copy link
Contributor

KimiWu123 commented Oct 26, 2023 •
edited
Loading

We have duplicated keccak_table in different place. The main goal of this issue is to merge them into one. Here are some previous comments:
#488 (comment)
#495 (comment)
@KimiWu123 KimiWu123 added good first issue Good for newcomers T-refactor Type: cleanup/refactor labels Oct 26, 2023
@KimiWu123 KimiWu123 mentioned this issue Oct 26, 2023
Merged
@mmjahanara
Copy link

Hey @KimiWu123
If this issue is still open, I'd like to take a stab at it!

@KimiWu123
Copy link
Contributor Author

Hi @mmjahanara, this issue is still open and feel free to take it!

@mmjahanara mmjahanara mentioned this issue Feb 18, 2024
Closed
@KimiWu123 KimiWu123 moved this to 🤝External Help in zkEVM Community Edition Feb 22, 2024
@ed255 ed255 linked a pull request Feb 22, 2024 that will close this issue
[WIP] Refactor/#499 clean up duplicated KeccakTable #513
Closed
@ed255 ed255 moved this from 🤝External Help to ✅ Done in zkEVM Community Edition Mar 7, 2024
@ChihChengLiang
Copy link
Collaborator

Close for we are deprecating Python implementation #518

@ChihChengLiang ChihChengLiang closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mmjahanara mmjahanara

Labels
good first issue Good for newcomers T-refactor Type: cleanup/refactor
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Refactor/#499 clean up duplicated KeccakTable mmjahanara/zkevm-specs
3 participants
@ChihChengLiang @mmjahanara @KimiWu123