diff --git a/.eslintrc b/.eslintrc
index e9539865dd..137d893825 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -136,6 +136,9 @@
"no-unused-vars": "off",
"import/no-default-export": "warn",
"no-underscore-dangle": "warn",
+ "react/require-default-props": "off",
+ "no-shadow": "off",
+ "@typescript-eslint/no-shadow": "error"
}
},
{
diff --git a/client/common/Button.stories.jsx b/client/common/Button.stories.jsx
index d11634ae28..0a0150a5b6 100644
--- a/client/common/Button.stories.jsx
+++ b/client/common/Button.stories.jsx
@@ -1,7 +1,7 @@
import React from 'react';
import { action } from '@storybook/addon-actions';
-import Button from './Button';
+import { Button, ButtonDisplays, ButtonKinds, ButtonTypes } from './Button';
import { GithubIcon, DropdownArrowIcon, PlusIcon } from './icons';
export default {
@@ -15,13 +15,13 @@ export default {
};
export const AllFeatures = (args) => (
-
+ );
+ expect(screen.getByLabelText('iconafter')).toBeInTheDocument();
+ expect(screen.getByRole('button')).toHaveTextContent(
+ 'This has an after icon'
+ );
+ });
+
+ it('renders only the icon if iconOnly', () => {
+ render(
+