Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify JobContext #1212

Open
onlyann opened this issue Oct 6, 2024 · 4 comments
Open

Simplify JobContext #1212

onlyann opened this issue Oct 6, 2024 · 4 comments
Milestone

Comments

@onlyann
Copy link
Contributor

onlyann commented Oct 6, 2024

The JobContext class mixes fields that are intended to be used by consumers of this library while other fields are used internally. 

As part of v3, it is a good time to clean up JobContext and only expose the fields that are intended for public use.
There is also the opportunity to simplify typing by removing the task field.

@onlyann onlyann mentioned this issue Oct 6, 2024
10 tasks
@medihack
Copy link
Member

Closed by #1213

@ewjoachim
Copy link
Member

(as seen in #1257 (comment), maybe the task was useful after all...)

@onlyann
Copy link
Contributor Author

onlyann commented Dec 25, 2024

(as seen in #1257 (comment), maybe the task was useful after all...)

Rather than reintroducing a circular reference with the task, how about adding useful fields directly on JobContext, such as the retry strategy instance in this case?

@ewjoachim
Copy link
Member

I think it was pretty useful to have the task there in the end. Is there really no simple way we can make it work for typing ?

@ewjoachim ewjoachim reopened this Dec 30, 2024
@ewjoachim ewjoachim added this to the Version 3.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants