Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetesControlPlane-prometheusRule] cluster_verb_scope:apiserver_request_sli_duration_seconds_count:increase30d calculation is wrong #2564

Open
StevenVdBGit opened this issue Dec 11, 2024 · 2 comments
Labels

Comments

@StevenVdBGit
Copy link

StevenVdBGit commented Dec 11, 2024

https://github.com/prometheus-operator/kube-prometheus/blame/17aa6690a5739183c68efa048439739dce773827/manifests/kubernetesControlPlane-prometheusRule.yaml#L789

This is wrong, copy/paste error. Should be increase1h{le="+Inf"} instead of increase30d{le="+Inf"} or remove the * 24 * 30 as is it already increase30d bucket

Now the count is multiplied twice with 24 * 30

Impact is that apiserver_request:availability30d is also wrong

@StevenVdBGit
Copy link
Author

Is related to kubernetes-monitoring/kubernetes-mixin#990

Copy link

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant