Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all goog.asserts calls with new custom asserting functions #136

Closed
lukesandberg opened this issue Sep 28, 2022 · 0 comments · Fixed by #137
Closed

Replace all goog.asserts calls with new custom asserting functions #136

lukesandberg opened this issue Sep 28, 2022 · 0 comments · Fixed by #137
Assignees
@dibenede
Labels
cleanup triaged Issue has been triaged

Comments

@lukesandberg
Copy link
Contributor

as part of #128 we are inadvertently disabling all goog.asserts calls (this is an intended side effect of ADVANCED_COMPILATION)

we should instead migrate to our own asserting functions that will survive compilation. This will also further progress on #135
@lukesandberg lukesandberg mentioned this issue Sep 28, 2022
Merged
@dibenede dibenede added the triaged Issue has been triaged label Sep 28, 2022
@dibenede dibenede self-assigned this Sep 29, 2022
@dibenede dibenede mentioned this issue Oct 5, 2022
Merged
@X-oss-byte X-oss-byte mentioned this issue May 24, 2024
Open
@thiswayman thiswayman mentioned this issue May 25, 2024
Open
@Suryaveersingh8055 Suryaveersingh8055 mentioned this issue Jun 5, 2024
Open
@VaniHaripriya VaniHaripriya mentioned this issue Jun 22, 2024
Open
@abhisheksurpur abhisheksurpur mentioned this issue Jul 11, 2024
Open
@kalbroni7 kalbroni7 mentioned this issue Jul 14, 2024
Open
@chenruibuaa chenruibuaa mentioned this issue Jul 22, 2024
Open
@thiswayman thiswayman mentioned this issue Aug 6, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Aug 15, 2024
Open
@ametial ametial mentioned this issue Aug 22, 2024
Open
@searce-nirav searce-nirav mentioned this issue Aug 31, 2024
Open
@swirlds-automation swirlds-automation mentioned this issue Sep 5, 2024
Open
@thiswayman thiswayman mentioned this issue Sep 7, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Sep 9, 2024
Open
@thiswayman thiswayman mentioned this issue Sep 14, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Sep 22, 2024
Open
@dazdaz dazdaz mentioned this issue Sep 30, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Oct 1, 2024
Open
@ambersnyk ambersnyk mentioned this issue Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibenede dibenede

Labels
cleanup triaged Issue has been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace goog.asserts and goog.testing.asserts dibenede/protobuf-javascript
2 participants
@lukesandberg @dibenede