From 5d15ba081f01290e27a132a4272fca1ea858f25f Mon Sep 17 00:00:00 2001 From: Stephanie DiBenedetto Date: Wed, 17 Jul 2024 09:53:08 -0700 Subject: [PATCH] Specify os and cpu for release name to avoid duplicates actions/upload-artifact@4 made a breaking change to fail on duplicate names. I think we are seeing Windows release errors as a result since both x64_x86 and x64 are named 'releases'. This change just tags the os and cpu onto the release dir name to reflect the specific build. --- .github/workflows/build.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 15b7a35..bda1111 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,10 +27,6 @@ jobs: node-version: 20 cache: ${{ !env.ACT && 'npm' || '' }} # cache API not available in ACT - - uses: bazel-contrib/setup-bazel@0.8.5 - with: - token: ${{ secrets.GITHUB_TOKEN }} - - name: Install Protoc run: | echo "Fetching protoc" @@ -108,7 +104,7 @@ jobs: - uses: actions/upload-artifact@v4 with: - name: releases + name: release-${{ matrix.os }}-${{ matrix.cpu }} path: out release: @@ -122,7 +118,7 @@ jobs: steps: - uses: actions/download-artifact@v4 with: - name: releases + name: release-${{ matrix.os }}-${{ matrix.cpu }} - name: Release uses: svenstaro/upload-release-action@v2