Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate marker supply query #1676

Open
4 tasks
Taztingo opened this issue Sep 8, 2023 · 2 comments
Open
4 tasks

Deprecate marker supply query #1676

Taztingo opened this issue Sep 8, 2023 · 2 comments
Milestone

Comments

@Taztingo
Copy link
Contributor

Taztingo commented Sep 8, 2023

Summary

The marker supply does not correctly output the total supply of a marker, and the correct functionality is already provided by the bank total query. It should be deprecated and later removed.

Problem Definition

There are two problems with this command. The first being that it is returning the initial supply rather than the total supply of a marker. The second issue is that the correct functionality already exists in another command. It does not make sense to have to manage and support this command.

Proposal

Deprecate the marker supply command.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller
Copy link
Member

This value is actually a "Target Supply" and is used when setting up a marker ... it shouldn't be used for non-fixed supply markers after they are activated since it doesn't apply anymore. The amount in circulation is always available from the bank which is a [potentially] different value.

For a "fixed supply" marker this value always applies and the invariant will mint/burn as required to pull the token into alignment with this configured supply target amount.

@hyperschwartz
Copy link

In some projects, I've found value in knowing the initial supply of a marker. It would be nice to have a new initial_supply field for referencing the value currently named supply on the MarkerAccount proto, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants