Make two new checks to discern between egress and ingress SG rules

[pedrooot]

New feature motivation

This check: ec2_securitygroup_allow_wide_open_public_ipv4 check if the security group has any rules that allow ingress or egress traffic. It does not differentiate between the two cases.

Solution Proposed

Make two new checks, one for egress and other for ingress.

Describe alternatives you've considered

Additional context

#4936

[abant07]

Hey @pedrooot, could I work on this issue

Thanks!

[pedrooot]

hey! @abant07 sure! It would be great!

[abant07]

Sounds good. I will do like I have done before. I will give a write up on the issue and how I intend to implement it.

[abant07]

Just to clarify, is the issue asking to make two separate checks for ec2_securitygroup_allow_wide_open_public_ipv4. One for ingress and the other for egress. Does the ec2_securitygroup_allow_wide_open_public_ipv4 check currently combine both ingress and egress check in 1 file? Or does it only contain ingress?

[pedrooot]

We are not sure about the development of these checks. Would you mind waiting until we decide what to do with them? This way, we won't discard your work. I'll let you know as soon as we make a decision, thanks for all Amogh

[abant07]

Sure no problem

[abant07]

Hey @pedrooot

In the meantime could I work on #4638

Thanks,
Amogh

[pedrooot]

Sure! It would be great! @abant07

[abant07]

Hey @pedrooot

Am I okay to go forward with this issue?

[pedrooot]

#4945 (comment)