Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS - IAM Role Cross Service Confused Deputy Prevention #7021

Open
harr-sudo opened this issue Feb 24, 2025 · 1 comment · May be fixed by #7023
Open

AWS - IAM Role Cross Service Confused Deputy Prevention #7021

harr-sudo opened this issue Feb 24, 2025 · 1 comment · May be fixed by #7023
Assignees
@HugoPBrito
Labels
bug provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.

Comments

@harr-sudo
Copy link

Steps to Reproduce

The finding fails to acknowledge that certain AWS Service Accounts that can assume IAM roles do not pass AWS:SourceArn AWS:SourceAccount in their request context and so the recommendation is not correct for these account types.

Expected behavior

Identify these accounts separately and suggest other hardening mechanisms.

Actual Result with Screenshots or Logs

n/a

How did you install Prowler?

Cloning the repository from github.com (git clone)

Environment Resource

n/a to the issue. Issue is with the way the finding identifies targets.

OS used

n/a to the issue

Prowler version

latest

Pip version

latest

Context

No response
@harr-sudo harr-sudo added bug status/needs-triage Issue pending triage labels Feb 24, 2025
@HugoPBrito HugoPBrito self-assigned this Feb 24, 2025
@HugoPBrito
Copy link
Member

Hi @harr-sudo!

It's true that the case you mention is not currently covered in the metadata. Since we cannot modify the metadata for specific individual resources, I will add the recommendation you suggested to that field, making it clear that there is no single recommendation, as it depends on the use case.

Thanks for reporting your suggestion, and for using Prowler :)

@HugoPBrito HugoPBrito linked a pull request Feb 24, 2025 that will close this issue
Open
7 tasks
@HugoPBrito HugoPBrito added severity/low Bug won't result in any noticeable breakdown of the execution. provider/aws Issues/PRs related with the AWS provider and removed status/needs-triage Issue pending triage labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HugoPBrito HugoPBrito

Labels
bug provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.
Projects
None yet
Milestone
No milestone
2 participants
@harr-sudo @HugoPBrito