fix(security-groups): remove RFC1918 from ec2_securitygroup_allow_wide_open_public_ipv4 #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_open_public_ipv4
github-actions
bot
added
the
provider/aws
jfagoagas
requested changes
Sep 6, 2024
...roup_allow_wide_open_public_ipv4/ec2_securitygroup_allow_wide_open_public_ipv4.metadata.json
Outdated
Show resolved
Hide resolved
...roup_allow_wide_open_public_ipv4/ec2_securitygroup_allow_wide_open_public_ipv4.metadata.json
Outdated
Show resolved
Hide resolved
jfagoagas
approved these changes
Sep 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4951 +/- ##
=======================================
Coverage 88.96% 88.97%
=======================================
Files 940 940
Lines 28777 28777
=======================================
+ Hits 25602 25604 +2
+ Misses 3175 3173 -2 ☔ View full report in Codecov by Sentry. |
jfagoagas
deleted the
fix-ec2_securitygroup_allow_wide_open_public_ipv4-metadata
branch
prowler-bot
added
the
was-backported
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mikkoc
reviewed
Sep 6, 2024
| @@ -10,7 +10,7 @@ | |||
| "ResourceIdTemplate": "arn:partition:service:region:account-id:resource-id", | |||
| "Severity": "high", | |||
| "ResourceType": "AwsEc2SecurityGroup", | |||
| "Description": "Ensure no security groups allow ingress and egress from wide-open non-RFC1918 address.", | |||
| "Description": "Ensure no security groups allow ingress and egress from ide-open IP address with a mask between 0 and 24.", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#4936
Description
This check only ensures that netmask from IP are between 0 and 24, both not included. Updated the metadata and comments from check.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.