Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional includes of launch files are not displayed #17

Open
matthiashh opened this issue Oct 3, 2019 · 2 comments
Open

Conditional includes of launch files are not displayed #17

matthiashh opened this issue Oct 3, 2019 · 2 comments

Comments

@matthiashh
Copy link

First of all thanks for the work put into this tool.

One thing I found missing is a visualization of conditions. For example in

  <!-- Gazebo  -->
  <include if="$(arg sim)" file="$(find bh_gazebo)/launch/gazebo.launch">
      <arg name="world" value="$(arg world)"/>
      <arg name="robot_name" value="dual_arm"/>
      <arg name="gui" value="$(arg gui)"/>
  </include>

the condition if="$(arg sim)" is not rendered in the GUI, but quite important when trying to understand launch files.

@pschillinger
Copy link
Owner

Unfortunately, this might not be straightforward. The implementation relies on the standard parsing by roslaunch to ensure that both tools always show the same behavior.

However, if you let roslaunch parse a file with conditions, it will immediately resolve them internally, i.e., a tag of which the condition is not true will not be reported at all. So far, I did not see a way how to do it without parsing the files independently from roslaunch.

I am happy to add the function if there is a way how to do this by using roslaunch.

@matthiashh
Copy link
Author

I think I misunderstood how the tool works. When I wrote the issue I thought it just ignores the conditions, but it actually honors them and will just display what it actually includes.

So what I brought up is more of a wish list thing to better fully understand how a launch file is structured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants