Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Critical] Black violates pep8 (E203) #544

Closed
DhiaTN opened this issue Oct 1, 2018 · 2 comments
Closed

[Critical] Black violates pep8 (E203) #544

DhiaTN opened this issue Oct 1, 2018 · 2 comments

Comments

@DhiaTN
Copy link

DhiaTN commented Oct 1, 2018 •
edited
Loading

Operating system: MacOS
Python version: 3.6
Black version: 18.9b0
Does also happen on master: yes

Black is violating pep8 rules while formatting, it's introducing spaces in list slices:

x/api.py:28:47: E203 whitespace before ':'
y/api.py:28:52: E203 whitespace before ':'
2     E203 whitespace before ':'

  • Original code:
    l = [i.name for i in x[_offset: _offset + _limit]]

  • Transformed code:
    l = [i.name for i in x[_offset : _offset + _limit]]
@DhiaTN DhiaTN changed the title Black violates E203, [Critical] Black violates pep8 (E203) Oct 1, 2018
@cas--
Copy link
Contributor

cas-- commented Oct 1, 2018

I believe this is correct for slicing:

See #280 and PyCQA/pycodestyle#373

@JelleZijlstra
Copy link
Collaborator

Indeed. This is also documented in https://github.com/ambv/black#slices.

chfw added a commit to moremoban/moban that referenced this issue Oct 26, 2018
@chfw
🎨 ignore E203, psf/black#544
f4688fa
jstasiak added a commit to jstasiak/kotlang that referenced this issue Feb 28, 2019
@jstasiak
Configure code formatting using black
90ee58d 
"E203 whitespace before ':'" ignored from now on, becuase [1] and [2].

[1] psf/black#544
[2] https://github.com/ambv/black#slices
@mwouts mwouts mentioned this issue Apr 5, 2020
Closed
@ichard26 ichard26 mentioned this issue Sep 13, 2020
Closed
@ichard26 ichard26 mentioned this issue Dec 4, 2020
Closed
@mightqxc mightqxc mentioned this issue Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cas-- @JelleZijlstra @DhiaTN