Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking.. #43

Closed
JMarkin opened this issue May 20, 2024 · 3 comments
Closed

Benchmarking.. #43

JMarkin opened this issue May 20, 2024 · 3 comments

Comments

@JMarkin
Copy link

JMarkin commented May 20, 2024

Hello, thank you for great job.

I added your driver to pgbeanch from MagicStack team. And result super different then your.
Full report https://public.jmarkin.ru/pgbeanch.html

Example result
image
psqlpy slower than all of other driver: aiopg, psycopg, asyncpg, etc.

Can you help me understand why your beanchmark give better results?

@chandr-andr
Copy link
Member

chandr-andr commented May 20, 2024

@JMarkin Hello! Thanks for testing the library. I'm going to look into it.
As for benchmark I made, I didn't want to show the raw performance of the library, so I tested it within FastAPI and not local PostgreSQL

As far as I know, MagicStack benchmark is a little strange cuz it shows that psycopg 5! times slower than asyncpg, I haven't seen such outperformance in any test I've made.

@chandr-andr
Copy link
Member

chandr-andr commented May 20, 2024

@JMarkin
Plus, you can check this issue (piccolo-orm/piccolo#986) with some discussion with the piccolo-orm creator and member, where we've tested asyncpg and psqlpy performance.
The difference isn't big (I explained why) but it's here.

Last but not least, you can check this repo https://github.com/ymezencev/db_perf, it uses the old version of psqlpy, but it beats the asyncpg.

@chandr-andr
Copy link
Member

Moved to discussions

@psqlpy-python psqlpy-python locked and limited conversation to collaborators Jul 4, 2024
@chandr-andr chandr-andr converted this issue into discussion #65 Jul 4, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants