Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with step object #1623

Open
rishabhshuklax opened this issue Feb 12, 2020 · 10 comments · May be fixed by #1673
Open

Problem with step object #1623

rishabhshuklax opened this issue Feb 12, 2020 · 10 comments · May be fixed by #1673
Labels

Comments

@rishabhshuklax
Copy link
Member

Please describe the problem (or idea)

Screenshot from 2020-02-12 22-54-18

Currently in the sequencer object there is a recursive loop of step inside options, we need to remove this!

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

rishabhshukla1999


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@YogeshSharma01
Copy link

Hi @blurry-x-face i want to claim this.

@YogeshSharma01
Copy link

Hi @blurry-x-face i want to work on this if nobody is working on this ?

@rishabhshuklax
Copy link
Member Author

Sure, go ahead!

@YogeshSharma01
Copy link

Hi @blurry-x-face can you please explain the issue ? and what we exactly we need to do ?

@harshkhandeparkar
Copy link
Member

The sequencer.steps array has multiple step objects. This is also the step object that is passed on to the defaultHtmlStepUi methods like onSetup and onComplete.

Each step object has an options object that stores the options passed on to the step from the UI. This options object has another step object which is identical to the original step object.

So each step object has recursive step objects. step > options > step > options > step > ..... and this continues for thousands of iterations.

We definitely don't want this. If you can fix it, it would be AWESOME.

@YogeshSharma01
Copy link

@harshkhandeparkar thanks! I'll try my best as its my first contribution after fto and I'll fix it.

@sjbcastro
Copy link

Hi @28-ys are you still working on this? Was thinking of having a look myself if you weren't looking at it any more. It's been a while since your last comment so I thought maybe you'd moved onto something else, just wanted to double check first.

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jun 8, 2020 via email

@sjbcastro sjbcastro linked a pull request Jun 9, 2020 that will close this issue
5 tasks
@sjbcastro
Copy link

Cool! I've put in a pull request here: #1673

It's my first time contributing to publiclab. I've created a pull request from a fork rather than a feature branch - will this be a problem?

Screenshot below of the resulting behaviour after the fix:

image

@harshkhandeparkar
Copy link
Member

Awesome! PRs are always opened from forks. Initially, using master branch is not a big issue. Ty :)

@harshkhandeparkar harshkhandeparkar added the has-pull-request Issues which have a PR open label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants