Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

Fix errors from enabling more jshint options #190

Closed
puffnfresh opened this issue Jul 29, 2013 · 1 comment
Closed

Fix errors from enabling more jshint options #190

puffnfresh opened this issue Jul 29, 2013 · 1 comment
Labels

Comments

@puffnfresh
Copy link
Owner

Just looking at the JSHint options. Chuck the following under grunt.initConfig:

jshint: {
    options: {
        //onevar: true,
        es3: true,
        indent: 4,
        noarg: true,
        node: true,
        trailing: true,
        undef: true,
        unused: true
    }
}

At the moment, looks like there's a few potential global leakages. We definitely don't want that.

I'm also proposing we use onevar soon. Just to enforce a style.

@jedws
Copy link
Collaborator

jedws commented Jul 29, 2013

indent 2 surely? :-)

cheers,
jed.

On 30/07/2013, at 8:53 AM, Brian McKenna [email protected] wrote:

Just looking at the JSHint options. Chuck the following under grunt.initConfig:

jshint: {
options: {
//onevar: true,
es3: true,
indent: 4,
noarg: true,
node: true,
trailing: true,
undef: true,
unused: true
}
}
At the moment, looks like there's a few potential global leakages. We definitely don't want that.

I'm also proposing we use onevar soon. Just to enforce a style.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants