Removed the ability to select md5, sha1, or sha224 as the checksum type #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
remove-old-checksums
branch
3 times, most recently
from
82a0778 to
e0eb410
Compare
|
I can split these into separate PRs if desired. The commits can be viewed separately and none of them will be backported though. |
dralley
force-pushed
the
remove-old-checksums
branch
5 times, most recently
from
2b26393 to
b9c7d9a
Compare
|
Also, I can merge the migrations |
ipanova
requested changes
Nov 10, 2023
pulp_rpm/app/constants.py
Outdated
| @@ -13,11 +13,6 @@ | |||
|
|
|||
| # The same as above, but in a format that choice fields can use | |||
| CHECKSUM_CHOICES = ( | |||
| (CHECKSUM_TYPES.UNKNOWN, CHECKSUM_TYPES.UNKNOWN), | |||
There was a problem hiding this comment.
Pretty sure it shouldn't have been there in the first place.
There was a problem hiding this comment.
apparently it's even used https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/tasks/synchronizing.py#L159
pulp_rpm/app/migrations/0056_rpmpublication_checksum_type_and_more.py
Outdated
Show resolved
Hide resolved
dralley
force-pushed
the
remove-old-checksums
branch
2 times, most recently
from
f6800c4 to
2451498
Compare
dralley
force-pushed
the
remove-old-checksums
branch
from
2451498 to
2c1eca6
Compare
github-actions
bot
added
the
multi-commit
dralley
force-pushed
the
remove-old-checksums
branch
2 times, most recently
from
3ca911e to
31e7bad
Compare
dralley
force-pushed
the
remove-old-checksums
branch
2 times, most recently
from
9f18e8c to
e215755
Compare
dralley
force-pushed
the
remove-old-checksums
branch
3 times, most recently
from
9ec1ce0 to
4b0a44b
Compare
|
@ipanova Now using a different approach: instead of changing the values allowed in the database (which as you pointed out is effectively unrestricted due to metadata mirroring and syncing), I just disallowed it in the serializer. |
dralley
force-pushed
the
remove-old-checksums
branch
from
4b0a44b to
fe66883
Compare
dralley
force-pushed
the
remove-old-checksums
branch
from
fe66883 to
f48ca86
Compare
ipanova
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sha256 has been supported since at least RHEL 6. We obviously still have to support syncing repos with md5, sha1, and sha224 checksums as they can theoretically exist in the wild (though less and less common over time) but there's really no reason to allow publishing with any weaker checksums. Especially since Katello has never exposed it.