Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At export, enforce content-order as a last-step. #3830

Merged
merged 1 commit into from
Dec 9, 2024
Merged

At export, enforce content-order as a last-step. #3830

merged 1 commit into from
Dec 9, 2024

Conversation

ggainey
Copy link
Contributor

@ggainey ggainey commented Dec 6, 2024

This avoids a rare deadlock on import-time involving ks-trees.

@ggainey
At export, enforce content-order as a last-step.
dfec44c 
This avoids a rare deadlock on import-time involving ks-trees.
@ggainey
Copy link
Contributor Author

ggainey commented Dec 6, 2024

Will re-run CI tests 10 times to see if this might address the deadlock we're seeing occasionally in the nightlies. It might not - this is just a hunch

@ggainey ggainey marked this pull request as ready for review December 7, 2024 00:00
@ggainey
Copy link
Contributor Author

ggainey commented Dec 7, 2024

We've passed 10 full test runs - I am (tentatively) happy that this solves the deadlock-window.

@ggainey ggainey requested review from dralley and mdellweg December 7, 2024 00:01
@ggainey ggainey merged commit 5d3d35c into pulp:main Dec 9, 2024
12 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 9, 2024 •
edited
Loading

Backport to 3.23: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.23/5d3d35c2fd9a5faf33348cdd91a5c832d909f2a1/pr-3830

Backported as #3839

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback Patchback
Copy link

patchback bot commented Dec 9, 2024 •
edited
Loading

Backport to 3.26: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.26/5d3d35c2fd9a5faf33348cdd91a5c832d909f2a1/pr-3830

Backported as #3840

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback Patchback
Copy link

patchback bot commented Dec 9, 2024 •
edited
Loading

Backport to 3.19: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.19/5d3d35c2fd9a5faf33348cdd91a5c832d909f2a1/pr-3830

Backported as #3841

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback Patchback
Copy link

patchback bot commented Dec 9, 2024 •
edited
Loading

Backport to 3.27: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.27/5d3d35c2fd9a5faf33348cdd91a5c832d909f2a1/pr-3830

Backported as #3838

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

This was referenced Dec 9, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

@mdellweg mdellweg Awaiting requested review from mdellweg

Assignees
No one assigned
Labels
backport-3.19 backport-3.23 backport-3.26 backport-3.27 no-changelog no-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggainey @dralley