Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django DEFAULT_FILE_STORAGE deprecated #5404

Open
pedro-psb opened this issue May 20, 2024 · 3 comments · May be fixed by #6058
Open

Django DEFAULT_FILE_STORAGE deprecated #5404

pedro-psb opened this issue May 20, 2024 · 3 comments · May be fixed by #6058
Assignees
@pedro-psb
Labels
Task
Milestone
3.70.0 blockers

Comments

@pedro-psb
Copy link
Member

The DEFAULT_FILE_STORAGE option was deprecated in django 4.2.0 in favor of another option called STORAGES.

Since we're using django~=4.2.0, we may want to change our docs (and possibly other places) to use the recommended way.
@pedro-psb pedro-psb added this to the 3.70.0 blockers milestone Nov 20, 2024
@pedro-psb pedro-psb self-assigned this Nov 20, 2024
pedro-psb added a commit to pedro-psb/pulpcore that referenced this issue Nov 20, 2024
@pedro-psb
Replace the DEFAULT_FILE_STORAGE settings with STORAGES
d873ab4 
The DEFAULT_FILE_STORAGE option was deprecated in django 4.2.0 in favor
of another option called STORAGES.

fixes pulp#5404
@pedro-psb pedro-psb linked a pull request Nov 20, 2024 that will close this issue
Draft
@pedro-psb
Copy link
Member Author

We can implement a compat layer in Pulp to keep existing installation happy and schedule that to be removed in the future (Pulp 4?).

Also, when we decide to remove it, we can point to django-upgrade to help upgrading: https://github.com/adamchainz/django-upgrade?tab=readme-ov-file#django-42

The advantage over doing anything is that we can update our code right away.

@ipanova
Copy link
Member

ipanova commented Nov 22, 2024

Mind that some plugins will be affected by this change, e.g. pulp_container

@mdellweg
Copy link
Member

Mind that some plugins will be affected by this change, e.g. pulp_container

Yes, we should align this with 3.70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedro-psb pedro-psb

Labels
Task
Projects
None yet
Milestone
3.70.0 blockers
Development

Successfully merging a pull request may close this issue.

[PULP-210] Update deprecated django storage config pedro-psb/pulpcore
4 participants
@ipanova @ggainey @pedro-psb @mdellweg