Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-next] context-menu of explorer doesn't work #1198

Open
5 tasks done
asiloisad opened this issue Jan 20, 2025 · 5 comments
Open
5 tasks done

[pulsar-next] context-menu of explorer doesn't work #1198

asiloisad opened this issue Jan 20, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@asiloisad
Copy link
Contributor

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

A context-menu PulsarNext Electron doesn't work. An error pop up.

Pulsar version

1.124.2025011501-next

Which OS does this happen on?

🪟 Windows

OS details

10

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

  1. Right click in folder of Windows Explorer
  2. Click PulsarNext Electron

Image

Additional Information:

No response

@asiloisad asiloisad added the bug Something isn't working label Jan 20, 2025
@asiloisad asiloisad changed the title [pulsar-next] context-menu doesn't work [pulsar-next] context-menu of explorer doesn't work Jan 20, 2025
@savetheclocktower
Copy link
Contributor

I didn't even know this was a thing.

@confused-Techie
Copy link
Member

Thanks a ton for reporting this issue!
This most certainly has to do with the fact the binary name has been changed to PulsarNext, and will likely be resolved by the time we properly ship the application.

Just to double check though, did you right click the folder itself, or the background page within a folder?

@asiloisad
Copy link
Contributor Author

If I turn on all options in Settings/System, then it revert to off after program reloaded/restarted.

Image

And there are two different context-menu items created by PulsarNext. Both don't work.

Image

@asiloisad
Copy link
Contributor Author

I have tested it

  • in context-menu of directory background,
  • in context-menu of directory,
  • in context-menu of file.

@confused-Techie
Copy link
Member

Interesting, thanks for the update.

Like I said, pretty sure this will be resolved once we revert the binary name back to just Pulsar, once PulsarNext is properly shipped.

But in the meantime, for anybody working on PulsarNext, this behavior is controlled in ./src/main-process/win-shell.js. The last few functions control what's actually added to the registry. A quick look doesn't have anything that pops out about why this would stop working, but based on the path shown in the error message of the issue, it seems maybe we aren't escaping a space or something if the installation path is truly Pulsar Next like I'm assuming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants