Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ship package-lock.json and yarn.lock #105

Open
aureq opened this issue Jan 9, 2025 · 1 comment
Open

Do not ship package-lock.json and yarn.lock #105

aureq opened this issue Jan 9, 2025 · 1 comment
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@aureq
Copy link
Member

aureq commented Jan 9, 2025

What happened?

Hi,

Working with @ekkohdev and discussing with @rquitales , it's quite possible that we shouldn't be shipping yarn.lock on the Node SDK as this is specific to yarn. Only package.json should be needed bundled with the Node SDK.

cp ../../README.md ../../LICENSE package.json yarn.lock bin/ && \

Opening an issue for visibility and getting confirmation on this.

Example

n/a

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@aureq aureq added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jan 9, 2025
@mjeffryes
Copy link
Member

That sounds about right. We need to update this boilerplate to use the latest templates from ci-mgmt, which should be more accurate wrt correct SDK packaging + publish.

@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants