Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner should not contain hard-coded values, it should be derived from configuration files. #103

Open
sooyean-hoo opened this issue Aug 19, 2024 · 0 comments · May be fixed by #104
Open

Runner should not contain hard-coded values, it should be derived from configuration files. #103

sooyean-hoo opened this issue Aug 19, 2024 · 0 comments · May be fixed by #104
Assignees
@sooyean-hoo
Labels
enhancement New feature or request

Comments

@sooyean-hoo
Copy link

sooyean-hoo commented Aug 19, 2024 •
edited
Loading

Describe the Bug

Line 45 and 70 of https://github.com/puppetlabs/cat-github-actions/blob/b98f1f160644f6e81b14df7fda190dc2bd8b62a3/.github/workflows/module_acceptance.yml are hardcoded

Expected Behavior

These should be derived.

Steps to Reproduce

N.A.
There are just code

Environment

  • ALL

Additional Context

N.A.
@sooyean-hoo sooyean-hoo added bug Something isn't working enhancement New feature or request labels Aug 19, 2024
@sooyean-hoo sooyean-hoo self-assigned this Aug 19, 2024
@sooyean-hoo sooyean-hoo removed the bug Something isn't working label Aug 19, 2024
@sooyean-hoo sooyean-hoo changed the title Runner shows not contain hard-coded values, it should be derived from configuration files. Runner should not contain hard-coded values, it should be derived from configuration files. Aug 19, 2024
@sooyean-hoo sooyean-hoo linked a pull request Aug 19, 2024 that will close this issue
Remove hardcoded version of ruby and puppet and replaced with values #104
Open
5 tasks
@sooyean-hoo sooyean-hoo linked a pull request Aug 19, 2024 that will close this issue
Open
5 tasks
@sooyean-hoo sooyean-hoo mentioned this issue Sep 3, 2024
Open
4 tasks
@sooyean-hoo sooyean-hoo linked a pull request Sep 3, 2024 that will close this issue
105 Add more flexible "module_acceptance_custom.yml" #107
Open
4 tasks
@sooyean-hoo sooyean-hoo removed a link to a pull request Sep 4, 2024
105 Add more flexible "module_acceptance_custom.yml" #107
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sooyean-hoo sooyean-hoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@sooyean-hoo