From 19c37d0483fa73dbc257e69af8fd89bfd77d9ce1 Mon Sep 17 00:00:00 2001 From: Michael Hashizume Date: Mon, 20 May 2024 16:08:13 -0700 Subject: [PATCH 1/2] Set test to pending due to JRuby bug JRuby 9.4.7.0, which the latest version of Puppet Server 8.x uses, does not properly parse IP addresses that mix IPv6 and IPv4 syntax (e.g. ::ffff:192.0.2.128). Because of this, we have filed a bug usptream and have set a test that uses that style of address to pending. See https://github.com/jruby/jruby/issues/8248 --- spec/facter/util/resolvers/networking/networking_spec.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/facter/util/resolvers/networking/networking_spec.rb b/spec/facter/util/resolvers/networking/networking_spec.rb index 095fe84b8c..edcd7aa5ac 100644 --- a/spec/facter/util/resolvers/networking/networking_spec.rb +++ b/spec/facter/util/resolvers/networking/networking_spec.rb @@ -54,6 +54,7 @@ let(:address) { '::ffff:192.0.2.128' } it 'returns scope6' do + pending('JRuby 9.4.7.0 does not properly parse mixed IPv6 addresses https://github.com/jruby/jruby/issues/8248') if RUBY_PLATFORM == 'java' && RUBY_VERSION == '3.1.4' expect(networking_helper.get_scope(address)).to eql('global') end end From d6b017e4d33d855173c6ebfc873dc3be882f12d4 Mon Sep 17 00:00:00 2001 From: Michael Hashizume Date: Mon, 20 May 2024 14:16:19 -0700 Subject: [PATCH 2/2] Add Puppet Server 8.x JRuby to unit tests This commit adds JRuby 9.4.7.0 to unit tests, which is the same version of JRuby that Puppet Server 8.x uses. (See: puppetlabs/jruby-utils@1180711.) --- .github/workflows/unit_tests.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/unit_tests.yaml b/.github/workflows/unit_tests.yaml index dd8b40859d..e37b9a4dfe 100644 --- a/.github/workflows/unit_tests.yaml +++ b/.github/workflows/unit_tests.yaml @@ -23,6 +23,7 @@ jobs: - '3.0' - '3.2' - 'jruby-9.3.14.0' + - 'jruby-9.4.7.0' runs-on: ubuntu-20.04 steps: - name: Checkout current PR