Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings with mirrored and aspectRatio #48

Open
benjamin-benoit opened this issue Oct 10, 2023 · 2 comments
Open

warnings with mirrored and aspectRatio #48

benjamin-benoit opened this issue Oct 10, 2023 · 2 comments

Comments

@benjamin-benoit
Copy link

benjamin-benoit commented Oct 10, 2023

Hello, I have two warnings with the lib, it's errors that we wan only fix in the lib:

Warning: Received `false` for a non-boolean attribute `mirrored`.

If you want to write it to the DOM, pass a string instead: mirrored="false" or mirrored={value.toString()}.

If you used to conditionally omit it with mirrored={condition && value}, pass mirrored={condition ? value : undefined} instead.
react-dom.development.js:86 Warning: React does not recognize the `aspectRatio`$ prop on a DOM element.

If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `aspectratio` instead.

If you accidentally passed it from a parent component, remove it from the DOM element.
@99power
Copy link

99power commented Oct 24, 2024

This only happens on React 19 afaik. I recently upgraded to Nextjs15 and React19 when these warnings started to show up, before it worked fine.

@99power
Copy link

99power commented Nov 1, 2024

This PR should fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants