Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change errorMessages in props to optional #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change errorMessages in props to optional #64

wants to merge 1 commit into from

Conversation

mst-mkt
Copy link

@mst-mkt mst-mkt commented Sep 4, 2024 •
edited
Loading

Issue

resolve #63

Description

The errorMessages in props was not set to optional and has been corrected.

  • before
<Camera /> // ❌ error: Property 'errorMessages' is missing in type '{ ref: RefObject<CameraType>; aspectRatio: number; }' but required in type 'CameraProps'.
  • after
<Camera /> // ⭕ ok

Also, I think it has been fixed that if each property of the errorMessages object was omitted, it did not work correctly internally.

  • before
<Camera errorMessages={{}} /> // errorMessages.noCameraAccessible <- string | undefined (inside component) ❌
  • after
<Camera errorMessages={{}} /> // errorMessages.noCameraAccessible <- string (inside component) ⭕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

errorMessages in props is not optional
1 participant
@mst-mkt