Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skills-Search rework: filter_params class rework #825

Open
3 tasks
RandomTannenbaum opened this issue Mar 4, 2025 · 0 comments
Open
3 tasks

Skills-Search rework: filter_params class rework #825

RandomTannenbaum opened this issue Mar 4, 2025 · 0 comments

Comments

@RandomTannenbaum
Copy link
Collaborator

RandomTannenbaum commented Mar 4, 2025

To reconstruct the fields of the skill search after a reload and for the view to have access to the results, we have a filter_params class that is provided as a helper by our filter_form controller. In this ticket we want to look over this class and clean it up.

Additionally, add the results directly to this class, so on initialization the results of the search, extracted from the query params, are directly delivered from this class. Then use these results in the view.

ToDo

  • The filter_params class is cleaned up as far as possible
  • The view now directly gets the search results from this class
  • Tests still pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant