Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skills-Search rework: Clean up views #826

Open
3 tasks
RandomTannenbaum opened this issue Mar 4, 2025 · 0 comments
Open
3 tasks

Skills-Search rework: Clean up views #826

RandomTannenbaum opened this issue Mar 4, 2025 · 0 comments

Comments

@RandomTannenbaum
Copy link
Collaborator

At the moment the skill search consists of multiple turbo frames and partials. We want to clean this up if possible. The current plan is to use the new (since Turbo 8) refresh Turbo Stream with morphing. When a filter is changed the form is submitted. The controller responds with the refresh Turbostream, which morphs the changed elements on the page and displays the updated results from the filter_params class.

The new button can be handled with something like a new query param, which causes the filter form controller to add a new filter to the filter params.

Similarly, the delete button could do the same and pass the row number to delete with the query param.

After these actions the controller also responds with the refresh turbo stream.

ToDo

  • Clean up the views, partials, stimulus controllers and turboframes as much as possible to have a clean, new solution
  • Make sure to use the morphing option when working with the refresh turbo stream to not cause full page reloads
  • Tests still run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant