Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HolidayDatabase.get_all_holiday_names() to have all options #189

Closed
2 tasks done
tsvi opened this issue Feb 3, 2025 · 0 comments · Fixed by #191
Closed
2 tasks done

Fix HolidayDatabase.get_all_holiday_names() to have all options #189

tsvi opened this issue Feb 3, 2025 · 0 comments · Fixed by #191

Comments

@tsvi
Copy link
Collaborator

tsvi commented Feb 3, 2025 •
edited
Loading

The get_all_holiday_names method is used by home assistant to determine valid values.

  • Now that we return both Shmini Atzeret and Simchat Torah in Israel for כ"ב תשרי, we should have that as an option returned by the method.
  • We should add an empty string for days when holiday returns an empty list.

This is blocking home-assistant/core#137247
@tsvi tsvi changed the title HolidayDatabase.get_all_holiday_names() should also return "Shmini Atzeret, Simchat Torah" as an option for non-diaspora Fix HolidayDatabase.get_all_holiday_names() to have all options Feb 3, 2025
@tsvi tsvi mentioned this issue Feb 4, 2025
Merged
4 tasks
@tsvi tsvi closed this as completed in #191 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add diaspora argument to get_all_holiday_names tsvi/py-libhdate
1 participant
@tsvi