Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: control displayed sponsors #1199

Merged
merged 5 commits into from
Jul 2, 2024
Merged

feat: control displayed sponsors #1199

merged 5 commits into from
Jul 2, 2024

Conversation

Ritabear
Copy link
Contributor

@Ritabear Ritabear commented Jun 16, 2024

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Describe what the change is
You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly
self-describe enough about how you change the code.

  • add a new variable is_show to manage sponsor data retrieval via the sponsor API.
  • testing for a new feature implementation.

issue related: #508

@Ritabear Ritabear requested review from mattwang44 and SivanYeh June 16, 2024 14:35
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (0fa2454) to head (2a232a0).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
+ Coverage   73.99%   74.01%   +0.02%     
==========================================
  Files          81       81              
  Lines        3057     3060       +3     
==========================================
+ Hits         2262     2265       +3     
  Misses        795      795              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/sponsors/models.py Show resolved Hide resolved
src/sponsors/tests/test_api.py Outdated Show resolved Hide resolved
src/sponsors/models.py Show resolved Hide resolved
Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SivanYeh SivanYeh merged commit 5c8448d into master Jul 2, 2024
3 checks passed
@SivanYeh SivanYeh deleted the feat/sponsor_control branch July 2, 2024 14:31
@SivanYeh SivanYeh restored the feat/sponsor_control branch July 2, 2024 14:43
@SivanYeh
Copy link
Collaborator

SivanYeh commented Jul 2, 2024

I tested it on staging and found previous logos would disappear.
Pasted Graphic 1

Is it normal? Should we inform sponsor team to recreate logos for new control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants