Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): fix rendering bug on sponsor section #513

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

rockleona
Copy link
Contributor

Types of changes

  • Bugfix

Description

Remove unnecessary line to prevent rendering side-effect on sponsor section.

Steps to Test This Pull Request

  1. checkout preview deploy

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for ephemeral-sable-89c7e0 ready!

Name Link
🔨 Latest commit fabb483
🔍 Latest deploy log https://app.netlify.com/sites/ephemeral-sable-89c7e0/deploys/662d0e59c31a83000867018e
😎 Deploy Preview https://deploy-preview-513--ephemeral-sable-89c7e0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rockleona rockleona marked this pull request as ready for review April 22, 2024 16:06
pages/index.vue Outdated Show resolved Hide resolved
@SivanYeh
Copy link
Collaborator

@baby230211 How about it?

@rockleona rockleona force-pushed the fix/render-sponsor branch from 74153a4 to 7d1c592 Compare April 27, 2024 14:04
@baby230211
Copy link
Collaborator

baby230211 commented Apr 27, 2024

As we discussed in discord, we found out that the asyncData return data name is conflicted with store data name.
Then we will get empty data from asyncData.

Due to asyncData is used for archived website, and it will be used for once a year.
i think it's fine to have a workaround on commenting out the code in asyncData.

@SivanYeh SivanYeh merged commit e6c2e9a into pycontw:main Apr 27, 2024
1 check passed
@SivanYeh SivanYeh linked an issue Apr 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][Sponsor]-sponsor logos disappear on stage/prod
3 participants