Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back reshape and broadcast_to with format selection #796

Open
hameerabbasi opened this issue Oct 22, 2024 · 5 comments
Open

Add back reshape and broadcast_to with format selection #796

hameerabbasi opened this issue Oct 22, 2024 · 5 comments

Comments

@hameerabbasi
Copy link
Collaborator

          > I see that the PR removes `reshape` and `broadcast_to`. Is it intended? I think these functions should stay as they are a part of Array API standard.

I was planning on adding them back as part of a follow-up PR, with some heuristics on the format selection.

Originally posted by @hameerabbasi in #792 (comment)

@prady0t
Copy link
Contributor

prady0t commented Mar 4, 2025

Can I help you with this if it's sill relevant?

@hameerabbasi
Copy link
Collaborator Author

@prady0t We're missing some primitives on the MLIR side to be able to do this efficiently. Reshape was added in #800, but we still need broadcast_to.

@prady0t
Copy link
Contributor

prady0t commented Mar 4, 2025

Thanks for the quick response! Could you point me to issues you might need help with? I would love to be of some use here 😅

@hameerabbasi
Copy link
Collaborator Author

@prady0t Could you maybe come over to the Discord linked in: https://scientific-python.org/community/#join-the-discussion? It'd be good to know your skill-set before telling you what would be good issues to solve.

@prady0t
Copy link
Contributor

prady0t commented Mar 4, 2025

Sure! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants