Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrthogonalMultidimensionalProfile from_dataframe raises NotImplementedError #51

Open
eldobbins opened this issue Jun 25, 2019 · 2 comments

Comments

@eldobbins
Copy link
Contributor

eldobbins commented Jun 25, 2019

I'm trying to write several CTD casts into a single netCDF file. This is following NCEI_Profile_Orthogonal. The data are in a single Pandas Dataframe with columns for pressure (z) and cast number (profile). However, from_dataset doesn't seem to exist..

I also have an issue with IncompleteMultidimensionalProfile, and submitted a separate ticket for that. (#52)

@kwilcox
Copy link
Member

kwilcox commented Jul 15, 2019

OrthogonalMultidimensionalProfile isn't implemented. Can you use IncompleteMultidimensionalProfile?

@eldobbins
Copy link
Contributor Author

I'm planning to set aside some time in early July to implement OrthogonalMultidimensionalProfile.from_dataframe. With 2 years more experience, I'm pretty sure I can do it.

For testing, I'd like to convert the netCDF files are that already in tests/dsg/profile/resources/ to CSV to see if I can regenerate the original netCDF files. So I would use Xarray and Pandas to write the data from om-multiple.nc and om-single.nc into CSV files. Then I'll transfer the attributes into a JSON file. Then in test_profile_om.py, I'll combine those and compare the result using the is_mine method that is already in om.py

If all goes well, I should have material for another Notebook to add to the documentation too.

Let me know if this sounds like the wrong approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants