Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build/host and run dependencies in meta.yaml #1476

Closed
rth opened this issue Apr 16, 2021 · 0 comments · Fixed by #2132
Closed

Separate build/host and run dependencies in meta.yaml #1476

rth opened this issue Apr 16, 2021 · 0 comments · Fixed by #2132
Labels

Comments

@rth
Copy link
Member

rth commented Apr 16, 2021

In meta.yaml I think it would make sense to differentiate between build/host and run dependencies, same as conda does https://conda-forge.org/docs/maintainer/adding_pkgs.html#build-host-and-run

This would,

  • improve the parallelism for building packages. Since for instance, a number of packages depend on scipy, by few actually need scipy to build, and right now all those packages are waiting for scipy to build.
  • allow us to explicitly check that build dependencies are available (and if necessary install them). Which should address issues like Flaky scipy build #936

Currently the problem for this migration is that we are using setup.py build which doesn't have a --no-deps version as far as I can tell, and so will fetch all dependencies at this step.

Another possible workaround I considered would be to monkeypatch socket.socket at install time to prevent internet access, but I think it's able to escape that as setuptools uses subprocess internally.

Also related to #795

@rth rth changed the title Separate build and run dependencies Separate build and run dependencies in meta.yaml Apr 16, 2021
@rth rth changed the title Separate build and run dependencies in meta.yaml Separate build/host and run dependencies in meta.yaml Apr 16, 2021
@hoodmane hoodmane added the build label Apr 19, 2021
@rth rth mentioned this issue Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants