3.5.0 Pre-release

[snowman2]

Release Candidate 0 Status:

• Linux ARM wheels (pyproj 3.5.0 PROJ 9.2.0 pyproj-wheels#56)
• Conda Forge (pyproj 3.5.0 conda-forge/pyproj-feedstock#134)
• Debian (@sebastic)
• Fedora (@jdkloe)

Plan to release in a few days. Testing is always appreciated, but definitely not required.

[sebastic]

The Debian package fails to build with proj (9.1.1-1) due to test failures:

=================================== FAILURES ===================================
__________________ test_transform_single_point_nad83_to_nad27 __________________

    def test_transform_single_point_nad83_to_nad27():
        # projection 1: UTM zone 15, grs80 ellipse, NAD83 datum
        # (defined by epsg code 26915)
        p1 = Proj("epsg:26915", preserve_units=False)
        # projection 2: UTM zone 15, clrk66 ellipse, NAD27 datum
        p2 = Proj("epsg:26715", preserve_units=False)
        # find x,y of Jefferson City, MO.
        x1, y1 = p1(-92.199881, 38.56694)
        # transform this point to projection 2 coordinates.
        x2, y2 = transform(p1, p2, x1, y1)
        assert_almost_equal(
            (x1, y1),
            (569704.566, 4269024.671),
            decimal=3,
        )
        expected_xy2 = (569722.342, 4268814.028)
        if PROJ_GTE_92:
            expected_xy2 = (569720.46, 4268813.88)
            if grids_available(
                "ca_nrc_ntv2_0.tif", "us_noaa_nadcon5_nad27_nad83_1986_conus.tif"
            ):
                expected_xy2 = (569722.394, 4268814.27)
            elif grids_available("ca_nrc_ntv2_0.tif", "ca_nrc_ntv1_can.tif"):
                expected_xy2 = (569706.333, 4268817.68)
            elif grids_available("us_noaa_conus.tif"):
                expected_xy2 = (569722.342, 4268814.028)
    
>       assert_almost_equal(
            (x2, y2),
            expected_xy2,
            decimal=3,
        )

test/test_transform.py:82: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/python3.11/contextlib.py:81: in inner
    return func(*args, **kwds)
/usr/lib/python3.11/contextlib.py:81: in inner
    return func(*args, **kwds)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

args = (<function assert_array_almost_equal.<locals>.compare at 0x7fc2773b98a0>, (569720.4595301996, 4268813.880212335), (569722.342, 4268814.028))
kwds = {'err_msg': '', 'header': 'Arrays are not almost equal to 3 decimals', 'precision': 3, 'verbose': True}

    @wraps(func)
    def inner(*args, **kwds):
        with self._recreate_cm():
>           return func(*args, **kwds)
E           AssertionError: 
E           Arrays are not almost equal to 3 decimals
E           
E           Mismatched elements: 2 / 2 (100%)
E           Max absolute difference: 1.8824698
E           Max relative difference: 3.30418813e-06
E            x: array([ 569720.46, 4268813.88])
E            y: array([ 569722.342, 4268814.028])

/usr/lib/python3.11/contextlib.py:81: AssertionError
_____________________ test_transform_tuple_nad83_to_nad27 ______________________

    def test_transform_tuple_nad83_to_nad27():
        # projection 1: UTM zone 15, grs80 ellipse, NAD83 datum
        # (defined by epsg code 26915)
        p1 = Proj("epsg:26915", preserve_units=False)
        # projection 2: UTM zone 15, clrk66 ellipse, NAD27 datum
        p2 = Proj("epsg:26715", preserve_units=False)
        # process 3 points at a time in a tuple
        lats = (38.83, 39.32, 38.75)  # Columbia, KC and StL Missouri
        lons = (-92.22, -94.72, -90.37)
        x1, y1 = p1(lons, lats)
        x2, y2 = transform(p1, p2, x1, y1)
        assert_almost_equal(
            x1,
            (567703.344, 351730.944, 728553.093),
            decimal=3,
        )
        assert_almost_equal(
            y1,
            (4298200.739, 4353698.725, 4292319.005),
            decimal=3,
        )
        expected_x2 = (567721.149, 351747.558, 728569.133)
        expected_y2 = (4297989.112, 4353489.645, 4292106.305)
        if PROJ_GTE_92:
            expected_x2 = (567719.249, 351748.119, 728568.053)
            expected_y2 = (4297989.776, 4353487.434, 4292108.075)
            if grids_available("us_noaa_nadcon5_nad27_nad83_1986_conus.tif"):
                expected_x2 = (567721.401, 351747.526, 728569.212)
                expected_y2 = (4297989.733, 4353489.752, 4292106.351)
            elif grids_available("ca_nrc_ntv2_0.tif", "ca_nrc_ntv1_can.tif"):
                expected_x2 = (567705.072, 351727.113, 728558.917)
                expected_y2 = (4297993.157, 4353490.111, 4292111.678)
            elif grids_available("us_noaa_conus.tif"):
                expected_x2 = (567721.149, 351747.558, 728569.133)
                expected_y2 = (4297989.112, 4353489.645, 4292106.305)
    
>       assert_almost_equal(
            x2,
            expected_x2,
            decimal=3,
        )

test/test_transform.py:130: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/python3.11/contextlib.py:81: in inner
    return func(*args, **kwds)
/usr/lib/python3.11/contextlib.py:81: in inner
    return func(*args, **kwds)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

args = (<function assert_array_almost_equal.<locals>.compare at 0x7fc2773ba700>, (567719.2492013731, 351748.1190794123, 728568.0526710057), (567721.149, 351747.558, 728569.133))
kwds = {'err_msg': '', 'header': 'Arrays are not almost equal to 3 decimals', 'precision': 3, 'verbose': True}

    @wraps(func)
    def inner(*args, **kwds):
        with self._recreate_cm():
>           return func(*args, **kwds)
E           AssertionError: 
E           Arrays are not almost equal to 3 decimals
E           
E           Mismatched elements: 3 / 3 (100%)
E           Max absolute difference: 1.89979863
E           Max relative difference: 3.34635874e-06
E            x: array([567719.249, 351748.119, 728568.053])
E            y: array([567721.149, 351747.558, 728569.133])

/usr/lib/python3.11/contextlib.py:81: AssertionError
=============================== warnings summary ===============================
.pybuild/cpython3_3.11_pyproj/build/test/test_datadir.py::test_get_data_dir__from_user[str]
.pybuild/cpython3_3.11_pyproj/build/test/test_datadir.py::test_get_data_dir__from_user[Path]
.pybuild/cpython3_3.11_pyproj/build/test/test_datadir.py::test_append_data_dir__internal[str]
.pybuild/cpython3_3.11_pyproj/build/test/test_datadir.py::test_append_data_dir__internal[Path]
  /build/python-pyproj-3.5.0~rc0/.pybuild/cpython3_3.11_pyproj/build/pyproj/datadir.py:38: UserWarning: pyproj unable to set database path.
    _global_context_set_data_dir()

.pybuild/cpython3_3.11_pyproj/build/test/test_doctest_wrapper.py::test_doctests
  /build/python-pyproj-3.5.0~rc0/.pybuild/cpython3_3.11_pyproj/build/pyproj/geod.py:827: UserWarning: Back azimuth is being returned by default to be compatible with inv()This is a breaking change for pyproj 3.5+.To avoid this warning, set return_back_azimuth=True.Otherwise, to restore old behaviour, set return_back_azimuth=False.This warning will be removed in future version.
    warnings.warn(

.pybuild/cpython3_3.11_pyproj/build/test/test_doctest_wrapper.py::test_doctests
  /build/python-pyproj-3.5.0~rc0/.pybuild/cpython3_3.11_pyproj/build/pyproj/geod.py:680: UserWarning: Back azimuth is being returned by default to be compatible with fwd()This is a breaking change for pyproj 3.5+.To avoid this warning, set return_back_azimuth=True.Otherwise, to restore old behaviour, set return_back_azimuth=False.This warning will be removed in future version.
    warnings.warn(

.pybuild/cpython3_3.11_pyproj/build/test/test_transform.py::test_transform_single_point_nad83_to_nad27
  /build/python-pyproj-3.5.0~rc0/.pybuild/cpython3_3.11_pyproj/build/test/test_transform.py:64: FutureWarning: This function is deprecated. See: https://pyproj4.github.io/pyproj/stable/gotchas.html#upgrading-to-pyproj-2-from-pyproj-1
    x2, y2 = transform(p1, p2, x1, y1)

.pybuild/cpython3_3.11_pyproj/build/test/test_transform.py::test_transform_tuple_nad83_to_nad27
  /build/python-pyproj-3.5.0~rc0/.pybuild/cpython3_3.11_pyproj/build/test/test_transform.py:104: FutureWarning: This function is deprecated. See: https://pyproj4.github.io/pyproj/stable/gotchas.html#upgrading-to-pyproj-2-from-pyproj-1
    x2, y2 = transform(p1, p2, x1, y1)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED test/test_transform.py::test_transform_single_point_nad83_to_nad27 - A...
FAILED test/test_transform.py::test_transform_tuple_nad83_to_nad27 - Assertio...
===== 2 failed, 928 passed, 1 skipped, 58 deselected, 8 warnings in 36.69s =====

These two tests succeed with proj (9.2.0-1~exp1) from Debian experimental

[snowman2]

Does PROJ 9.1.1 have this patch applied?

conda-forge/proj.4-feedstock#130

[snowman2]

Related: #1213

[sebastic]

Does PROJ 9.1.1 have this patch applied?

conda-forge/proj.4-feedstock#130

No patches are applied to proj (9.1.1-1) in Debian.

The commit referenced in that issue is included in 9.2.0.

[jdkloe]

This pre-release looks good on fedora-rawhide(39) which has proj version 9.2.0.

[snowman2]

Thanks @sebastic @jdkloe for testing 👍

[sebastic]

Will test failures with 9.1.1 be addressed or PROJ_MIN_VERSION bumped to 9.2.0?

[snowman2]

The plan is to address the failures before the release. Need to get time to replicate the issue and address it 😄

[snowman2]

#1258

[snowman2]

Based on the investigation, the conda-forge patch fixes the behavior. I think skipping PROJ 9.1.1 is a good idea. I added xfail for those tests in case you would like to build with 9.1.1 as well.