Address the issues in #3274 #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `support = constraints.real_vector` to `MixtureOfDiagNormals` and `MixtureOfDiagNormalsSharedCovariance` * Fixed the white noise sampling bug in the `forward` method of `_MixDiagNormalSample` * Same call in `_MixDiagNormalSample` and `_MixDiagNormalSharedCovarianceSample` to generate white noise * Harmonized tensor shape error messages between `MixtureOfDiagNormals` and `MixtureOfDiagNormalsSharedCovariance` * Added the correct class name in tensor shape errors for `MixtureOfDiagNormalsSharedCovariance`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3274
support = constraints.real_vectortoMixtureOfDiagNormalsandMixtureOfDiagNormalsSharedCovarianceforwardmethod of_MixDiagNormalSample_MixDiagNormalSampleand_MixDiagNormalSharedCovarianceSampleto generate white noiseMixtureOfDiagNormalsandMixtureOfDiagNormalsSharedCovarianceMixtureOfDiagNormalsSharedCovariancemake formatwent through without problems.make lintruns with the change noted in issue #3276 but fails with some type errors in pyro/optim. This is not related to any changes I made here. The rest of the linting goes through without a problem.