Fix the display of the "Errors" panel in the SLO detail dashboard #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, if we do want to show the actual percentage error rate, we could change the query for the panel to |
This panel actually shows the rate of errors occurring but is configured to display this as percentunit. This results in it showing a 200% error rate when there are actually 2 errors occurring per second. Change the unit for this panel to reqps instead.
LukeDAtkinson
force-pushed
the
fix-grafana-dashboard-errors-panel
branch
from
cc09451 to
2d03a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This panel actually shows the rate of errors occurring but is configured to display this as percentunit. This results in it showing a 200% error rate when there are actually 2 errors occurring per second. Change the unit for this panel to reqps instead.