Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import samtools/bcftools/htslib 1.20 #1289

Closed
wants to merge 2 commits into from

Conversation

ilia-kats
Copy link

No description provided.

@jmarshall
Copy link
Member

jmarshall commented Oct 9, 2024

Thanks for your PR, which is fairly comprehensively done. I wanted to fix the fclosing-stdout thing a different way (by not closing it in samtools/bamtk.c.pysam.c), and it has now been superseded by PR #1310, which imports 1.21.

(Incidentally pysam.sort("-n", …) has always sorted by name; SAMtools v1.19 merely introduced -N with a slightly different name-sorted sort order.)

@jmarshall jmarshall closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants