Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up PY2 stuff and improve code structure #36

Open
walterddr opened this issue Jul 31, 2022 · 1 comment
Open

Clean up PY2 stuff and improve code structure #36

walterddr opened this issue Jul 31, 2022 · 1 comment
Assignees

Comments

@walterddr
Copy link
Collaborator

lots of python2 __future__ import is still in pinot-dbapi.

Several clean ups.

  • clean up py2 stuff
  • add typing
  • split codes in db.py
    • type and column processing into separate file
    • query response processing / data manipulation into separate file

It seems like we still have lots to do to support more sqlalchemy features. but will left that into separate issues, potentially we can leverage the type / column / schema / data utils split out from db.py

@walterddr walterddr self-assigned this Aug 19, 2022
@walterddr
Copy link
Collaborator Author

py2 stuff is cleaned up.
ci is added.

next will try to add typing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant