Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table names seem to get dropped from joins etc. #98

Closed
abloom opened this issue Apr 25, 2024 · 0 comments
Closed

Table names seem to get dropped from joins etc. #98

abloom opened this issue Apr 25, 2024 · 0 comments

Comments

@abloom
Copy link
Contributor

abloom commented Apr 25, 2024

While working on some queries for my team I noticed that table names weren't present in my join statements and occasionally this was causing issues with ambiguous column names.

I started to look through the code and think the issue is in some old code in the visit_column function. I've opened PR #97 which then uncovered what I suspect is another bug involving types. I can open a separate issue/PR for that if you prefer.

I understand PR #97 may not be the right solution, I admit the code is not entirely clear to me even after looking at the commit history of the relevant lines. I would be happy to submit a better solution but may need some help understanding the implementation.

@abloom abloom closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant