Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are tests intended to be distributed? #86

Closed
dhirschfeld opened this issue Jul 13, 2023 · 2 comments
Closed

Are tests intended to be distributed? #86

dhirschfeld opened this issue Jul 13, 2023 · 2 comments

Comments

@dhirschfeld
Copy link
Member

dhirschfeld commented Jul 13, 2023

After installing trio-typing using the pypi wheel I see the below files being installed:

❯ tree -I __pycache__ /opt/mambaforge/envs/test/lib/python3.10/site-packages/trio_typing
/opt/mambaforge/envs/test/lib/python3.10/site-packages/trio_typing
├── __init__.py
├── __init__.pyi
├── _tests
│   ├── __init__.py
│   ├── datadriven.py
│   ├── test-data
│   │   ├── async_generator.test
│   │   ├── open-mode.test
│   │   ├── outcome.test
│   │   ├── taskstatus.test
│   │   └── trio-basic.test
│   ├── test_runtime.py
│   └── test_typecheck.py
├── _version.py
├── plugin.py
└── py.typed

2 directories, 14 files

Are the tests intended to be distributed - I think that's not usual?

@dhirschfeld
Copy link
Member Author

Not a big issue, just posting for informational purposes.

If this library is merged into trio itself (as suggested in #75) then this is moot, so can probably just wait until that happens.

@oremanj
Copy link
Member

oremanj commented Dec 1, 2023

I did it this way because Trio did. I don't have a strong opinion, but since this is about to be obsoleted by Trio upstream type hints, I'm not going to rock the boat at the moment.

@oremanj oremanj closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants