Skip to content

WASM build step does something weird with prefix #92744

Open
@zooba

Description

@zooba

I have a build that uses a full path for configure --prefix=....

As of 3.11.0b1, this path is combined in the Makefile with a . for WASM_ASSETS_DIR which then is used for WASM_STDLIB, which is then passed to rm -rf in clean-retain-profile.

cpython/Makefile.pre.in

Lines 249 to 251 in a834e2d

# assets for Emscripten browser builds
WASM_ASSETS_DIR=".$(prefix)"
WASM_STDLIB="$(WASM_ASSETS_DIR)/local/lib/python$(VERSION)/os.py"

-rm -rf $(WASM_STDLIB)

Because my path does not combine nicely, the above rm -rf seems to be wrong:

rm -rf ""./home/vsts/work/1/a/layout"/local/lib/python3.11/os.py"
...

(Why we're trying to rm -r a single file I don't even know, but maybe there's a reason.)

Any ideas? @tiran?

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.11only security fixes3.12only security fixesOS-emscriptenbuildThe build process and cross-build

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions