From 21aec9792e5d04cf347bd23038c4751433d8692c Mon Sep 17 00:00:00 2001
From: Yann Sionneau <yann@sionneau.net>
Date: Tue, 14 Feb 2023 19:47:05 +0100
Subject: [PATCH] Petition.is_allowed_to_edit(): Code cleanup

The code was a mess, if (x) return True else return False => return x
---
 pytition/petition/models.py | 29 ++++++++++++-----------------
 1 file changed, 12 insertions(+), 17 deletions(-)

diff --git a/pytition/petition/models.py b/pytition/petition/models.py
index c001d870..f695f102 100644
--- a/pytition/petition/models.py
+++ b/pytition/petition/models.py
@@ -382,23 +382,18 @@ def is_allowed_to_edit(self, user):
         Check if a user is allowed to edit this petition
         """
         if self.owner_type == "user":
-            if self.user == user:
-                # The user is the owner of the petition
-                return True
-            else:
-                return False
-        else:
-            # But it is an org petition
-            try:
-                perm = Permission.objects.get(
-                    organization=self.org,
-                    user=user
-                )
-            except Permission.DoesNotExist:
-                # No such permission, denied
-                return False
-            else:
-                return perm.can_modify_petitions
+            # The user is the owner of the petition
+            return self.user == user
+        # But it is an org petition
+        try:
+            perm = Permission.objects.get(
+                organization=self.org,
+                user=user
+            )
+        except Permission.DoesNotExist:
+            # No such permission, denied
+            return False
+        return perm.can_modify_petitions
 
     @property
     def url(self):