up

Author: metascroy

torchao/csrc/cpu/CMakeLists.txt

@@ -26,7 +26,19 @@ option(TORCHAO_BUILD_TESTS "Build tests" OFF)
 option(TORCHAO_BUILD_BENCHMARKS "Build tests" OFF)
 
 # Set default compiler options
-add_compile_options("-fPIC" "-Wall" "-Werror" "-Wno-deprecated" "-Wno-shorten-64-to-32")
+add_compile_options("-fPIC" "-Wall" "-Werror" "-Wno-deprecated")
+if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
+    add_compile_options(
+        "-Wno-error=unknown-pragmas"
+        "-Wno-array-parameter"
+        "-Wno-maybe-uninitialized"
+        "-Wno-sign-compare"
+    )
+elseif (APPLE)
+    add_compile_options("-Wno-shorten-64-to-32")
+endif()
+
+
 
 if (NOT TARGET cpuinfo)
     cmake_policy(PUSH)
@@ -96,17 +108,6 @@ if(TORCHAO_BUILD_CPU_AARCH64)
     message(STATUS "Building with cpu/aarch64")
     add_compile_definitions(TORCHAO_BUILD_CPU_AARCH64)
 
-    # Set aarch64 compiler options
-    if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
-        message(STATUS "Add aarch64 linux compiler options")
-        add_compile_options(
-            "-Wno-error=unknown-pragmas"
-            "-Wno-array-parameter"
-            "-Wno-maybe-uninitialized"
-            "-Wno-sign-compare"
-        )
-    endif()
-
     if(TORCHAO_ENABLE_ARM_NEON_DOT)
         message(STATUS "Building with ARM NEON dot product support")
         add_compile_definitions(TORCHAO_ENABLE_ARM_NEON_DOT)

torchao/csrc/cpu/shared_kernels/benchmarks/CMakeLists.txt

@@ -24,66 +24,3 @@ set(TARGET_PREFIX "torchao_benchmarks_shared_kernels_")
 #     benchmark::benchmark
 #     torchao_kernels_aarch64
 # )
-
-
-
-
-
-
-# add_executable(${TARGET_PREFIX}benchmark_quantization benchmark_quantization.cpp)
-# target_link_libraries(
-#     ${TARGET_PREFIX}benchmark_quantization
-#     PRIVATE
-#     benchmark::benchmark
-#     ${TARGET_PREFIX}dep
-# )
-
-# add_executable(${TARGET_PREFIX}benchmark_bitpacking benchmark_bitpacking.cpp)
-# target_link_libraries(
-#     ${TARGET_PREFIX}benchmark_bitpacking
-#     PRIVATE
-#     benchmark::benchmark
-#     ${TARGET_PREFIX}dep
-# )
-
-
-
-
-# cmake_minimum_required(VERSION 3.19)
-# project(benchmarks)
-
-# set(CMAKE_CXX_STANDARD 17)
-# set(CMAKE_BUILD_TYPE Release)
-# add_compile_options("-Wall" "-Werror")
-
-# set(TORCHAO_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../..)
-# set(TORCHAO_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/../../../..)
-
-# include(FetchContent)
-# FetchContent_Declare(googlebenchmark
-#         GIT_REPOSITORY https://github.com/google/benchmark.git
-#         GIT_TAG main) # need main for benchmark::benchmark
-
-# set(BENCHMARK_ENABLE_TESTING OFF)
-# FetchContent_MakeAvailable(
-#   googlebenchmark)
-
-# include_directories(${TORCHAO_INCLUDE_DIRS})
-
-# set(TORCHAO_PARALLEL_BACKEND "openmp")
-
-# include(${TORCHAO_ROOT}/Utils.cmake)
-
-# add_subdirectory(${TORCHAO_ROOT}/kernels/cpu/aarch64 ${CMAKE_CURRENT_BINARY_DIR}/torchao_kernels_aarch64)
-
-# add_executable(benchmark_linear_8bit_act_xbit_weight
-#   benchmark_linear_8bit_act_xbit_weight.cpp
-#   ${TORCHAO_ROOT}/ops/linear_8bit_act_xbit_weight/linear_8bit_act_xbit_weight.cpp
-# )
-# target_link_torchao_parallel_backend(benchmark_linear_8bit_act_xbit_weight "${TORCHAO_PARALLEL_BACKEND}")
-# target_link_libraries(
-#     benchmark_linear_8bit_act_xbit_weight
-#     PRIVATE
-#     benchmark::benchmark
-#     torchao_kernels_aarch64
-# )