Skip to content

[exir] MemoryPlanning Verifier assumes that if a model has a user input it has at least 1 tensor input. #10522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JacobSzwejbka opened this issue Apr 28, 2025 · 1 comment · May be fixed by #10617
Open

[exir] MemoryPlanning Verifier assumes that if a model has a user input it has at least 1 tensor input. #10522

JacobSzwejbka opened this issue Apr 28, 2025 · 1 comment · May be fixed by #10617
Labels
good first issue Good for newcomers module: exir Issues related to Export IR and the code under exir/

Comments

@JacobSzwejbka
Copy link
Contributor

JacobSzwejbka commented Apr 28, 2025 •
edited by pytorch-bot bot
Loading

🐛 Describe the bug

Prim inputs are uncommon because of how export generally traces them away. Dynamic prim int inputs are coming soon though and our memory planning verifier currently blows up if all the user inputs are prims. We need to improve the logic of the _do_user_inputs_exist to probably just return false if all the inputs are prims.

Versions

.

cc @angelayi
@JacobSzwejbka JacobSzwejbka added the good first issue Good for newcomers label Apr 28, 2025
@JacobSzwejbka JacobSzwejbka added the module: exir Issues related to Export IR and the code under exir/ label Apr 28, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch Core Apr 28, 2025
@jhelsby jhelsby linked a pull request May 1, 2025 that will close this issue
Open
@jhelsby
Copy link
Contributor

jhelsby commented May 1, 2025

Hi, I'd be interested in taking this issue if it's still available. I have created a draft PR here: #10617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers module: exir Issues related to Export IR and the code under exir/
Projects
ExecuTorch Core
Status: To triage
New Contributors Projects and Issues
Status: No status
Milestone
No milestone
2 participants
@jhelsby @JacobSzwejbka