Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bucketized model averaging for LocalSGD #66

Open
d4l3k opened this issue Jan 10, 2025 · 1 comment
Open

Use bucketized model averaging for LocalSGD #66

d4l3k opened this issue Jan 10, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@d4l3k
Copy link
Member

d4l3k commented Jan 10, 2025

We want to implement the bucketization from https://github.com/pytorch/pytorch/blob/main/torch/distributed/algorithms/model_averaging/utils.py#L22-L50

Instead of our naive per parameter reduction here: https://github.com/pytorch/torchft/blob/main/torchft/local_sgd.py#L179-L181

@d4l3k d4l3k added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2025
@distributedstatemachine

I would love to take this on .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants