Fix optimizer check edge case (#3058)

Summary:
Pull Request resolved: #3058

There's an edge case for detecting an optimizer - where no optimizer is applied during backwards, but the compute kernel is fused, so techncially an EBC.optimizer would be created.

In this case for dynamic sharding, we still don't need to store any optimizers - I've added the condition to properly check for optimizers to pass the unit test.

Reviewed By: TroyGarden

Differential Revision: D76203188

fbshipit-source-id: f1e18b9a71ab1168ef0f2704f86f1751403d4799

Author: aporialiao

torchrec/distributed/embeddingbag.py

@@ -1533,7 +1533,9 @@ def update_shards(
             return
 
         current_state = self.state_dict()
-        has_optimizer = len(self._optim._optims) > 0
+        has_optimizer = len(self._optim._optims) > 0 and all(
+            len(i) > 0 for i in self._optim.state_dict()["state"].values()
+        )
 
         # TODO: Saving lookups tensors to CPU to eventually avoid recreating them completely again
         # TODO: Ensure lookup tensors are actually being deleted