You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With GTK4's new file chooser grid view (See: https://release.gnome.org/44/) nearing its roll-out with Gnome 44 and Chromium's GTK4 support with the flag --gtk-version=4, it be great to see gtk-dark-mode-switch-fix.patch updated to also accommodate org.freedesktop.appearance.color-scheme.I'd hate to have to choose between auto theme switching and the improved file chooser grid view.
With GTK4's new file chooser grid view (See: https://release.gnome.org/44/) nearing its roll-out with Gnome 44 and Chromium's GTK4 support with the flag
--gtk-version=4
, it be great to seegtk-dark-mode-switch-fix.patch
updated to also accommodateorg.freedesktop.appearance.color-scheme
.I'd hate to have to choose between auto theme switching and the improved file chooser grid view.I don't typically code in C++, but was thinking:
GtkCheckVersion
(https://github.com/chromium/chromium/blob/f69ece76596ef7c5db931570d102c3284a700ef8/ui/gtk/gtk_compat.h#L45) to conditionally define some new variables to based as args toset_use_dark_colors
andset_preferred_color_scheme
org.freedesktop.appearance.color-scheme
, but I'm not positive because I don't typically code desktop/GTK apps.--gtk-version
flagWhen I have a little downtime I'm going to make an attempt to update your patch for my local Ungoogled Chromium builds
The text was updated successfully, but these errors were encountered: